[CIR] Add initial support for bit-precise integer types #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Hi, this is cool, thanks! You say initial support, what's remaining here?
Few extra things this PR needs:
- Add LLVM lowering support, and add tests similar from
clang/test/CodeGen/ext-int.candclang/test/CodeGen/ext-int-cc.c. I'm open to this being follow up work, but it probably goes well with the size of this PR. - A bunch of constraints in tablegen assume int types of the primitive ones, so we need to refine those or split them into more variants. Example
CIR_IntType,CIR_AnyIntOrFloat,IntOrFPPtr,IntegerVector(We either need a better name for them, or change how they are defined). You need to go through each user in CIROps.td and check whether it makes sense for the operations to use anything other than canonical primite types when ints are involved.
|
@sitio-couto you might be interested in this. |
Well, I'm just not sure whether the changes in this PR is sufficient for a full support, or there are still some unnoticed cases that needs to be resolved. Tests do not follow up that quickly.
Added. Tests that require unimplemented features are not added for now.
Updated. |
Sounds good, just out of curiosity.
Thanks |
bcardosolopes
requested changes
Apr 11, 2024
This patch adds support for the bit-precise integer type `_BitInt(N)`. This type goes into the C23 standard, and has already been supported by clang since 2020, previously known as `_ExtInt(N)`. Basically this patch leverages the existing `cir.int` type to represent such types. Previously `cir.int` verifies that its width must be a multiple of 8, and this verification has been removed in this patch.
|
Rebased onto the latest |
bcardosolopes
approved these changes
Apr 15, 2024
| // We only provide alias for standard integer types (i.e. integer types | ||
| // whose width is divisible by 8). | ||
| if (intType.getWidth() % 8 != 0) | ||
| return AliasResult::NoAlias; |
There was a problem hiding this comment.
Not a blocker for this PR, but why not?
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR adds initial support for the bit-precise integer type `_BitInt(N)`. This type goes into the C23 standard, and has already been supported by clang since 2020, previously known as `_ExtInt(N)`. This PR is quite simple and straight-forward. Basically it leverages the existing `cir.int` type to represent such types. Previously `cir.int` verifies that its width must be a multiple of 8, and this verification has been removed in this PR.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR adds initial support for the bit-precise integer type `_BitInt(N)`. This type goes into the C23 standard, and has already been supported by clang since 2020, previously known as `_ExtInt(N)`. This PR is quite simple and straight-forward. Basically it leverages the existing `cir.int` type to represent such types. Previously `cir.int` verifies that its width must be a multiple of 8, and this verification has been removed in this PR.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
This PR adds initial support for the bit-precise integer type `_BitInt(N)`. This type goes into the C23 standard, and has already been supported by clang since 2020, previously known as `_ExtInt(N)`. This PR is quite simple and straight-forward. Basically it leverages the existing `cir.int` type to represent such types. Previously `cir.int` verifies that its width must be a multiple of 8, and this verification has been removed in this PR.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR adds initial support for the bit-precise integer type `_BitInt(N)`. This type goes into the C23 standard, and has already been supported by clang since 2020, previously known as `_ExtInt(N)`. This PR is quite simple and straight-forward. Basically it leverages the existing `cir.int` type to represent such types. Previously `cir.int` verifies that its width must be a multiple of 8, and this verification has been removed in this PR.
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
This PR adds initial support for the bit-precise integer type `_BitInt(N)`. This type goes into the C23 standard, and has already been supported by clang since 2020, previously known as `_ExtInt(N)`. This PR is quite simple and straight-forward. Basically it leverages the existing `cir.int` type to represent such types. Previously `cir.int` verifies that its width must be a multiple of 8, and this verification has been removed in this PR.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
This PR adds initial support for the bit-precise integer type `_BitInt(N)`. This type goes into the C23 standard, and has already been supported by clang since 2020, previously known as `_ExtInt(N)`. This PR is quite simple and straight-forward. Basically it leverages the existing `cir.int` type to represent such types. Previously `cir.int` verifies that its width must be a multiple of 8, and this verification has been removed in this PR.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
This PR adds initial support for the bit-precise integer type `_BitInt(N)`. This type goes into the C23 standard, and has already been supported by clang since 2020, previously known as `_ExtInt(N)`. This PR is quite simple and straight-forward. Basically it leverages the existing `cir.int` type to represent such types. Previously `cir.int` verifies that its width must be a multiple of 8, and this verification has been removed in this PR.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This PR adds initial support for the bit-precise integer type `_BitInt(N)`. This type goes into the C23 standard, and has already been supported by clang since 2020, previously known as `_ExtInt(N)`. This PR is quite simple and straight-forward. Basically it leverages the existing `cir.int` type to represent such types. Previously `cir.int` verifies that its width must be a multiple of 8, and this verification has been removed in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for the bit-precise integer type
_BitInt(N). This type goes into the C23 standard, and has already been supported by clang since 2020, previously known as_ExtInt(N).This PR is quite simple and straight-forward. Basically it leverages the existing
cir.inttype to represent such types. Previouslycir.intverifies that its width must be a multiple of 8, and this verification has been removed in this PR.